[Pdl-porters] [Perldl] sf bug #3391645 - compatibility clarification
joel.a.berger at gmail.com
Thu Nov 10 05:57:03 HST 2011
Just a curiousity: what do you mean that PDL is not 64bit safe? I have been
using it on a 64bit computer for years, is there something I should be
On Thu, Nov 10, 2011 at 8:55 AM, Chris Marshall <devel.chm.01 at gmail.com>wrote:
> Some tips that I have found useful for git development:
> - Always start a development session with git pull
> - Keep fixes small and coherent (e.g., fix one problem
> at a time), this makes each commit message good
> documentation for the development process and it allows
> backtracking for bugs to be isolated to a single commit
> which makes it easier to fix things with git
> - Always test your fixes with a complete PDL build and
> tests (including the configure unless you know the change
> is not affected/does not affect the configure process) before
> any commit or patch submission. That keeps the pdl git
> basically working which makes it easier to develop for all.
> - I also do a final git pull just before commit so that any
> merges that need to take place can happen before the
> push or patch.
> As far as the printf format specs fixes, the %p sounds
> good to me. One thing to look out for is format specs
> that might be affected by 64bit issues. PDL is not
> yet 64bit safe but that is planned. Thanks for helping
> with the cleanup.
> On Thu, Nov 10, 2011 at 7:21 AM, David Mertens <dcmertens.perl at gmail.com>
> > Hi Tim -
> > There are lots of options depending on your familiarity with git. If you
> > were a registered PDL developer, you would make your edits, commit, and
> > push. If you were very familiar with git, you would make your edits,
> > and tell us where we could pull your changes (i.e. you'd make a pull
> > request). However, as you are not familiar with git, here is what I
> > you do:
> > Make your edits, save the files. Do *not* commit via git.
> > git diff > fix-pointers.patch
> > Attach the patch to an email. One of the porters will apply it in your
> > Preferably these sorts of communications would be sent to
> > pdl-porters at jach.hawaii.edu, but that's not a strong preference. We'll
> > patches however we can get them. :-)
> > David
> > P.S. Aren't you one of the Chicago Perlmongers?
> > On Thu, Nov 10, 2011 at 2:04 AM, Tim Haines <communist.goatboy at gmail.com
> > wrote:
> >> Greetings, all.
> >> This bug report is some general cleanup of several printf format flags.
> >> Currently, pointer values are being printed out like this
> >> int *i;
> >> printf("0x%x",i);
> >> which generates a warning since %x wants an unsigned int instead of a
> >> pointer. I propose changing this to
> >> int *i;
> >> printf("%p",(void*)i);
> >> As best I can tell, the %p flag is ANSI compliant. Does anyone have any
> >> objection to using it?
> >> Since this bug fix affects several files and I don't have any experience
> >> using Git, is there a tutorial somewhere that outlines your preferred
> >> of doing a check-in of multiple files and their associated comments? I
> >> `git clone git://pdl.git.sourceforge.net/gitroot/pdl/pdl my_dir` to
> >> the latest repository.
> >> Thanks.
> >> - Tim
> >> _______________________________________________
> >> Perldl mailing list
> >> Perldl at jach.hawaii.edu
> >> http://mailman.jach.hawaii.edu/mailman/listinfo/perldl
> > _______________________________________________
> > Perldl mailing list
> > Perldl at jach.hawaii.edu
> > http://mailman.jach.hawaii.edu/mailman/listinfo/perldl
> Perldl mailing list
> Perldl at jach.hawaii.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the PDL-porters